Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Optimize some hot spot under 10k collections #33235

Closed
1 task done
xiaofan-luan opened this issue May 21, 2024 · 1 comment
Closed
1 task done

[Enhancement]: Optimize some hot spot under 10k collections #33235

xiaofan-luan opened this issue May 21, 2024 · 1 comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@xiaofan-luan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

[
profile.zip
](url)

this pr optimize grpc interceptor and some select function

Why is this needed?

No response

Anything else?

No response
@xiaofan-luan xiaofan-luan added the kind/enhancement Issues or changes related to enhancement label May 21, 2024
@xiaofan-luan xiaofan-luan mentioned this issue May 21, 2024
Closed
@stale Stale
Copy link

stale bot commented Jun 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 21, 2024
@stale stale bot closed this as completed Jun 28, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jul 1, 2024
@congqixia
enhance: Use channel name map finding channel watcher
9817e83 
See also milvus-io#33235

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 1, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 1, 2024
@congqixia
enhance: Use channel name map finding channel watcher (#34294)
e083d99 
See also #33235

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 1, 2024
@congqixia
enhance: Use channel name map finding channel watcher (milvus-io#34294)
324e8bb 
See also milvus-io#33235

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 1, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 2, 2024
@congqixia
enhance: [2.4] Use channel name map finding channel watcher (#34294) (#…
fc69b10 
…34309)

Cherry-pick from master
pr: #34294
See also #33235

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@congqixia @yellow-shine
enhance: Use channel name map finding channel watcher (milvus-io#34294)
06fe2ef 
See also milvus-io#33235

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 17, 2024
@congqixia
enhance: Remove useless ops when there is no write
9639963 
Related to milvus-io#33235

THe querynode pipeline will make map & call ProcessInsert when there is
no write messages. So querynodes will have high CPU usage even when
there is no workload.

This PR check msg length before composing data struct and calling method

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 17, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 19, 2024
@congqixia
enhance: Remove useless ops when there is no write (#34767)
2ac7164 
Related to #33235

THe querynode pipeline will make map & call ProcessInsert when there is
no write messages. So querynodes will have high CPU usage even when
there is no workload.

This PR check msg length before composing data struct and calling method

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 19, 2024
@congqixia
enhance: Remove useless ops when there is no write (milvus-io#34767)
324b2a2 
Related to milvus-io#33235

THe querynode pipeline will make map & call ProcessInsert when there is
no write messages. So querynodes will have high CPU usage even when
there is no workload.

This PR check msg length before composing data struct and calling method

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 19, 2024
@congqixia
enhance: Remove useless ops when there is no write (milvus-io#34767)
9cf23e8 
Related to milvus-io#33235

THe querynode pipeline will make map & call ProcessInsert when there is
no write messages. So querynodes will have high CPU usage even when
there is no workload.

This PR check msg length before composing data struct and calling method

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 19, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jul 19, 2024
@congqixia
enhance: Remove useless ops when there is no write (milvus-io#34767)
13ea56e 
Related to milvus-io#33235

THe querynode pipeline will make map & call ProcessInsert when there is
no write messages. So querynodes will have high CPU usage even when
there is no workload.

This PR check msg length before composing data struct and calling method

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 22, 2024
@congqixia
enhance: [2.4] Remove useless ops when there is no write (#34767) (#3…
c06a0eb 
…4839)

Cherry pick from master
pr: #34767
Related to: #33235

THe querynode pipeline will make map & call ProcessInsert when there is
no write messages. So querynodes will have high CPU usage even when
there is no workload.

This PR check msg length before composing data struct and calling method

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance: optimize some hot spot function for 10k collections xiaofan-luan/milvus
1 participant
@xiaofan-luan