Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: the server will not work properly when using a non-existent db #33243

Closed
1 task done
SimFG opened this issue May 22, 2024 · 2 comments
Closed
1 task done

[Bug]: the server will not work properly when using a non-existent db #33243

SimFG opened this issue May 22, 2024 · 2 comments
Assignees
@SimFG
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@SimFG
Copy link
Contributor

SimFG commented May 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

When using a db that does not exist, the rate limit interceptor will panic because the db information cannot be obtained.
image

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@SimFG SimFG added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 22, 2024
@SimFG
Copy link
Contributor Author

SimFG commented May 22, 2024

/assign @SimFG

@SimFG SimFG mentioned this issue May 22, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 22, 2024
@SimFG
fix: the panic when db isn't existed in the rate limit interceptor (#…
dd0c6d6 
…33244)

issue: #33243

Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG SimFG mentioned this issue May 23, 2024
Merged
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 23, 2024
@yanliang567 yanliang567 removed their assignment May 23, 2024
sre-ci-robot pushed a commit that referenced this issue May 23, 2024
@SimFG
enhance: [2.4] the panic when db isn't existed in the rate limit inte…
37b2f90 
…rceptor (#33308)

issue: #33243
pr: #33244

1. fix: the panic when db isn't existed in the rate limit interceptor
#33244
2. enhance: check the auth in some rest v2 api #33256

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
@stale Stale
Copy link

stale bot commented Jun 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 22, 2024
@SimFG SimFG closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimFG SimFG

Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimFG @yanliang567