Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Pre-allocate space for datanode insert buffer preventing frequent grow slice #33561

Open
1 task done
congqixia opened this issue Jun 3, 2024 · 1 comment
Open
1 task done

[Enhancement]: Pre-allocate space for datanode insert buffer preventing frequent grow slice #33561

congqixia opened this issue Jun 3, 2024 · 1 comment
Assignees
@congqixia
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Pre-allocate insert buffer capacity in datanode

Why is this needed?

After profiling datanode CPU usage, the growslice happen frequently when write stress is heavy

Anything else?

There is one drawback that the memory consumption may be notable when using partition key feature
@congqixia congqixia added the kind/enhancement Issues or changes related to enhancement label Jun 3, 2024
@congqixia congqixia self-assigned this Jun 3, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jun 3, 2024
@congqixia
enhance: Pre-allocate insert buffer capacity for writebuffer
e55cf88 
See also milvus-io#33561

This PR:
- Adds a new param item for insert buffer chunk size
- Pre-allocate for each insert buffer preventing frequent `growslice`

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 3, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jun 11, 2024
@congqixia
enhance: Pre-allocate insert buffer capacity for writebuffer
eeaca07 
See also milvus-io#33561

This PR:
- Adds a new param item for insert buffer chunk size
- Pre-allocate for each insert buffer preventing frequent `growslice`

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 13, 2024
@congqixia
enhance: Avoid merging insert data when buffering insert msgs (#33562)
512ea6b 
See also #33561

This PR:
- Use zero copy when buffering insert messages
- Make `storage.InsertCodec` support serialize multiple insert data
chunk into same batch binlog files

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jun 13, 2024
@congqixia
enhance: Reserve space of payload writer when serialize data
b66167d 
See also milvus-io#33561 milvus-io#33562

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 13, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jun 13, 2024
@congqixia
enhance: Reserve space of payload writer when serialize data
9fc721f 
See also milvus-io#33561 milvus-io#33562

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 17, 2024
@congqixia
enhance: Reserve space of payload writer when serialize data (#33817)
f993b29 
See also #33561 #33562

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jun 26, 2024
@congqixia
enhance: Avoid merging insert data when buffering insert msgs (milvus…
bb33bdd 
…-io#33562)

See also milvus-io#33561

This PR:
- Use zero copy when buffering insert messages
- Make `storage.InsertCodec` support serialize multiple insert data
chunk into same batch binlog files

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jun 26, 2024
@congqixia
enhance: Reserve space of payload writer when serialize data (milvus-…
8624942 
…io#33817)

See also milvus-io#33561 milvus-io#33562

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 26, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 27, 2024
@congqixia
enhance: [2.4] Avoid merging insert data when buffering insert msgs (#…
f741bb7 
…34205)

Cherry-pick from master
pr: #33526 #33817
See also #33561

This PR:
- Use zero copy when buffering insert messages
- Make `storage.InsertCodec` support serialize multiple insert data
chunk into same batch binlog files

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@congqixia @yellow-shine
enhance: Avoid merging insert data when buffering insert msgs (milvus…
b8eca18 
…-io#33562)

See also milvus-io#33561

This PR:
- Use zero copy when buffering insert messages
- Make `storage.InsertCodec` support serialize multiple insert data
chunk into same batch binlog files

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@congqixia @yellow-shine
enhance: Reserve space of payload writer when serialize data (milvus-…
c61818d 
…io#33817)

See also milvus-io#33561 milvus-io#33562

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@stale Stale
Copy link

stale bot commented Jul 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia