Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Async warmup doesn't work #33685

Closed
1 task done
bigsheeper opened this issue Jun 6, 2024 · 1 comment
Closed
1 task done

[Bug]: Async warmup doesn't work #33685

bigsheeper opened this issue Jun 6, 2024 · 1 comment
Assignees
@chyezh
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@bigsheeper
Copy link
Contributor

bigsheeper commented Jun 6, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master&2.4
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Load segment progress is blocked by LoadStateLock in warmup, so async warmup becomes a sync operation.
image
image

Expected Behavior

Ensure async warmup remains async.

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@bigsheeper bigsheeper added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2024
This was referenced Jun 6, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 7, 2024
@chyezh
fix: async warmup will be blocked by state lock (#33687)
93348af 
issue: #33685
pr: #33686

Signed-off-by: chyezh <chyezh@outlook.com>
sre-ci-robot pushed a commit that referenced this issue Jun 10, 2024
@chyezh
fix: async warmup will be blocked by state lock (#33686)
8ca5ced 
issue: #33685

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh
Copy link
Contributor

chyezh commented Jun 13, 2024

should be fixed

@chyezh chyezh closed this as completed Jun 13, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@chyezh @yellow-shine
fix: async warmup will be blocked by state lock (milvus-io#33686)
e937ce8 
issue: milvus-io#33685

Signed-off-by: chyezh <chyezh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chyezh chyezh

Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chyezh @bigsheeper