Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: integration test TestCompaction/TestL0Compaction is not stable #33716

Closed
1 task done
congqixia opened this issue Jun 7, 2024 · 4 comments
Closed
1 task done

[Bug]: integration test TestCompaction/TestL0Compaction is not stable #33716

congqixia opened this issue Jun 7, 2024 · 4 comments
Assignees
@XuanYang-cn @czs007
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 1629833
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

integration test TestCompaction/TestL0Compaction is not stable

Expected Behavior

integration test shall pass stable

Steps To Reproduce

No response

Milvus Log

[2024/06/07 06:31:54.693 +00:00] [INFO] [datacoord/compaction_trigger.go:709] [generatePlans] [collectionID=0] [plan_num=0]
    l0_compaction_test.go:192: 
        	Error Trace:	/go/src/github.com/milvus-io/milvus/tests/integration/compaction/l0_compaction_test.go:192
        	Error:      	waiting for compaction timeout
        	Test:       	TestCompaction/TestL0Compaction

Anything else?

https://github.com/milvus-io/milvus/actions/runs/9411451505/job/25927310033?pr=33710
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 7, 2024
@XuanYang-cn
Copy link
Contributor

/assign @czs007

congqixia added a commit to congqixia/milvus that referenced this issue Jun 13, 2024
@congqixia
fix: Skip enable integration test for master
9b8e63f 
See also milvus-io#33716 milvus-io#33823

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 13, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 13, 2024
@congqixia
fix: [skip e2e] Skip unstable integration test for master (#33824)
144ee26 
See also #33716 #33823

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jun 21, 2024
@congqixia
enhance: Add ctx in SyncTask.Run to be cancellable
ff107bd 
Related to milvus-io#33716

This PR add context param in SyncTask.Run execution functions to make it
cancellable from the caller.

This make it possible to cancel task when datanode/data sync service is
beeing shut down.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 21, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jun 22, 2024
@congqixia
enhance: Add ctx in SyncTask.Run to be cancellable
a593d85 
Related to milvus-io#33716

This PR add context param in SyncTask.Run execution functions to make it
cancellable from the caller.

This make it possible to cancel task when datanode/data sync service is
beeing shut down.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jun 24, 2024
@congqixia
enhance: Add ctx in SyncTask.Run to be cancellable
5c463df 
Related to milvus-io#33716

This PR add context param in SyncTask.Run execution functions to make it
cancellable from the caller.

This make it possible to cancel task when datanode/data sync service is
beeing shut down.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 25, 2024
@congqixia
enhance: Add ctx in SyncTask.Run to be cancellable (#34042)
962a544 
Related to #33716

This PR add context param in SyncTask.Run execution functions to make it
cancellable from the caller.

This make it possible to cancel task when datanode/data sync service is
beeing shut down.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@congqixia @yellow-shine
fix: [skip e2e] Skip unstable integration test for master (milvus-io#…
f0b1613 
…33824)

See also milvus-io#33716 milvus-io#33823

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@congqixia @yellow-shine
enhance: Add ctx in SyncTask.Run to be cancellable (milvus-io#34042)
ac0875f 
Related to milvus-io#33716

This PR add context param in SyncTask.Run execution functions to make it
cancellable from the caller.

This make it possible to cancel task when datanode/data sync service is
beeing shut down.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@stale Stale
Copy link

stale bot commented Jul 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jul 7, 2024
@XuanYang-cn
Copy link
Contributor

keep it

@stale stale bot removed the stale indicates no udpates for 30 days label Jul 9, 2024
@stale Stale
Copy link

stale bot commented Aug 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XuanYang-cn XuanYang-cn

@czs007 czs007

Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XuanYang-cn @czs007 @congqixia