Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: filter results less than topk #33933

Closed
1 task done
foxspy opened this issue Jun 17, 2024 · 2 comments
Closed
1 task done

[Bug]: filter results less than topk #33933

foxspy opened this issue Jun 17, 2024 · 2 comments
Assignees
@foxspy
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@foxspy
Copy link
Collaborator

foxspy commented Jun 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

With graph ann search, the search result may contains less than topk results when the filter ratio is really high. This search case should be handled carefully and return sufficient results to meet the topk constraint.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@foxspy foxspy added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 17, 2024
@foxspy foxspy mentioned this issue Jun 17, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 17, 2024
@alwayslove2013
fix: filter results less than topk (#33930)
2e01ae9 
issue: #33933

Signed-off-by: min.tian <min.tian.cn@gmail.com>
@alwayslove2013 alwayslove2013 mentioned this issue Jun 18, 2024
Merged
@yanliang567
Copy link
Contributor

/assign @foxspy
/unassign

@sre-ci-robot sre-ci-robot assigned foxspy and unassigned yanliang567 Jun 18, 2024
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 18, 2024
sre-ci-robot pushed a commit that referenced this issue Jun 18, 2024
@alwayslove2013
fix filter results less than topk (hotfix-2.3.15) (#33931)
b4c4181 
issue: #33933 
Strict filtering can affect the quality of graph-based search results.
In extreme cases, it may return less than topk results. The upgraded
`Knowhere` has updated strategy decision-making to address this issue.

Signed-off-by: min.tian <min.tian.cn@gmail.com>
@stale Stale
Copy link

stale bot commented Jul 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jul 19, 2024
@stale stale bot closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foxspy foxspy

Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foxspy @yanliang567