Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support unset properties when using attu #34151

Closed
1 task done
xige-16 opened this issue Jun 25, 2024 · 9 comments
Closed
1 task done

[Enhancement]: Support unset properties when using attu #34151

xige-16 opened this issue Jun 25, 2024 · 9 comments
Assignees
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@xige-16
Copy link
Contributor

xige-16 commented Jun 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

  1. we can use pymilvus.collection.set_properties or attu to set collection's properties, Then we can only modify these properties manually, but you cannot cancel these properties and use the system default values.
  2. a warning log issue: Reset invalid properties zilliztech/attu#547

So when set property value == "", the behavior can be changed to cancel the manual setting of properties.

Why is this needed?

No response

Anything else?

No response

@xige-16 xige-16 added the kind/enhancement Issues or changes related to enhancement label Jun 25, 2024
@shanghaikid
Copy link
Contributor

how to unset them via sdk?

@xige-16 xige-16 assigned xiaofan-luan and xige-16 and unassigned xiaofan-luan Jun 25, 2024
@xige-16
Copy link
Contributor Author

xige-16 commented Jun 25, 2024

how to unset them via sdk?

Didn't see any corresponding python function

@xige-16
Copy link
Contributor Author

xige-16 commented Jul 2, 2024

Is this pr OK?

@jaime0815
Copy link
Contributor

jaime0815 commented Jul 2, 2024

It may conflict with some configurations that the value can be configured to "". we can support add and remove actions to enhance the alter function. @xige-16

@xige-16
Copy link
Contributor Author

xige-16 commented Jul 4, 2024

we can support add and remove

If some configurations need to be set to "", then setting the default value of these configurations to "" can achieve the same effect. Anyway, waiting for your updates. @jaime0815

@jaime0815
Copy link
Contributor

It has different effects: @xige-16

  1. Setting the property value to "" by default removes this property during the alter operation, which is treated as invalid.

  2. Setting the property value to "" may also be useful for this property, but this deeply depends on the implementation.

@xiaofan-luan
Copy link
Contributor

it's better to support a fucntion to remove.

But it seems to fine to keep "" as not set?

@xiaofan-luan
Copy link
Contributor

@xige-16
i think it 's fine to rebase and merge it

Copy link

stale bot commented Aug 31, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 31, 2024
@stale stale bot closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Development

No branches or pull requests

4 participants