Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Refactor wrapper and knowhere #342

Closed
JinHai-CN opened this issue Nov 15, 2019 · 1 comment · Fixed by #1687
Closed

[FEATURE] Refactor wrapper and knowhere #342

JinHai-CN opened this issue Nov 15, 2019 · 1 comment · Fixed by #1687
Assignees
@cydrain @wxyucs @tinkerlin
Labels
kind/enhancement Issues or changes related to enhancement
Projects
0.8.0
Milestone
2020 Q1

Comments

@JinHai-CN
Copy link
Contributor

Currently, before we use real engine to search / insert. There are too many wrapper which is complex. Remove and merge some unused part.
@JinHai-CN JinHai-CN added the kind/enhancement Issues or changes related to enhancement label Nov 15, 2019
@JinHai-CN JinHai-CN added this to To do in v0.6.0 via automation Nov 15, 2019
@cydrain cydrain removed this from To do in v0.6.0 Dec 31, 2019
@cydrain cydrain added this to To do in Backlog via automation Dec 31, 2019
@JinHai-CN JinHai-CN added this to the 2020 Q1 milestone Dec 31, 2019
@JinHai-CN
Copy link
Contributor Author

Please paste the document link.

@JinHai-CN JinHai-CN added this to To do in 0.8.0 via automation Feb 29, 2020
@JinHai-CN JinHai-CN removed this from To do in Backlog Feb 29, 2020
@cydrain cydrain mentioned this issue Mar 17, 2020
Merged
0.8.0 automation moved this from To do to Done Mar 19, 2020
jaime0815 pushed a commit to jaime0815/milvus that referenced this issue Nov 18, 2022
@yhmo
Add test case for all supported indexed (milvus-io#342)
a505b3e 
Signed-off-by: groot <yihua.mo@zilliz.com>
yah01 pushed a commit to yah01/milvus that referenced this issue Feb 13, 2023
@eddyxu
[Python] lance.write_dataset takes pandas DataFrame (milvus-io#342)
2c77acc 
Write_dataset takes pandas dataframe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cydrain cydrain

@wxyucs wxyucs

@tinkerlin tinkerlin

Labels
kind/enhancement Issues or changes related to enhancement
Projects
No open projects
0.8.0
  
Done
Milestone
2020 Q1
Development

Successfully merging a pull request may close this issue.

Caiyd refactor knowhere
4 participants
@cydrain @wxyucs @tinkerlin @JinHai-CN