Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [Cherry-pick] Merge query stream result for reduce delete task (#32855) #34281

Merged
merged 1 commit into from
Jul 3, 2024
Merged

enhance: [Cherry-pick] Merge query stream result for reduce delete task (#32855) #34281

merged 1 commit into from
Jul 3, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jul 1, 2024

relate: #32854
pr: #32855

@aoiasd aoiasd changed the title enhance: Merge query stream result for reduce delete task (#32855) enhance: [Cherry-pick] Merge query stream result for reduce delete task (#32855) Jul 1, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 1, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.32%. Comparing base (7ee4ccb) to head (306e92c).
Report is 17 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34281      +/-   ##
==========================================
+ Coverage   81.46%   82.32%   +0.86%     
==========================================
  Files        1028      768     -260     
  Lines      132427   110772   -21655     
==========================================
- Hits       107879    91198   -16681     
+ Misses      20474    15480    -4994     
- Partials     4074     4094      +20
Files Coverage Δ
internal/querynodev2/handlers.go 80.00% <100.00%> (ø)
internal/querynodev2/server.go 64.35% <100.00%> (-11.34%) ⬇️
internal/querynodev2/tasks/query_stream_task.go 81.39% <100.00%> (+1.39%) ⬆️
pkg/util/paramtable/component_param.go 98.44% <100.00%> (-0.03%) ⬇️
internal/util/streamrpc/streamer.go 77.31% <78.12%> (+0.94%) ⬆️

... and 444 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 2, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Jul 2, 2024

/run-cpu-e2e

@czs007 czs007 added this to the 2.4.6 milestone Jul 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
enhance: Merge query stream result for reduce delete task (milvus-io#…
306e92c 
…32855)

relate: milvus-io#32854

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 3, 2024
congqixia
congqixia approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7000cec into milvus-io:2.4 Jul 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.4.6
Development

Successfully merging this pull request may close these issues.
4 participants
@aoiasd @czs007 @sre-ci-robot @congqixia