Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Skip pick worker when task doesn't need to execute actually #34348

Merged
merged 1 commit into from
Jul 3, 2024
Merged

enhance: Skip pick worker when task doesn't need to execute actually #34348

merged 1 commit into from
Jul 3, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #34347

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Skip pick worker when task doesn't need to execute actually
775615e 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.4.6 milestone Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.30137% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (3563136) to head (775615e).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34348      +/-   ##
==========================================
- Coverage   79.32%   79.31%   -0.02%     
==========================================
  Files        1095     1095              
  Lines      137819   137825       +6     
==========================================
- Hits       109330   109310      -20     
- Misses      24346    24368      +22     
- Partials     4143     4147       +4
Files Coverage Δ
internal/datacoord/index_service.go 94.92% <100.00%> (ø)
internal/datacoord/task_scheduler.go 100.00% <100.00%> (ø)
internal/datacoord/task_analyze.go 85.95% <81.81%> (+0.15%) ⬆️
internal/datacoord/task_index.go 87.50% <86.04%> (+0.16%) ⬆️

... and 25 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added need-cherry-pick PR | need cherry-pick need cherry pick to other branches and removed need-cherry-pick labels Jul 3, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.6, 2.5.0 Jul 3, 2024
@xiaocai2333 xiaocai2333 mentioned this pull request Jul 3, 2024
Merged
@mergify mergify bot added the ci-passed label Jul 3, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 3, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit feb13cd into milvus-io:master Jul 3, 2024
12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 3, 2024
@xiaocai2333
enhance: [cherry-pick] Skip pick worker when task doesn't need to exe…
e944c30 
…cute actually (#34382)

issue: #34347 

master pr: #34348

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 5, 2024
@xiaocai2333 xiaocai2333 deleted the skip_pick_node branch July 9, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@sunby sunby Awaiting requested review from sunby

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaocai2333 @czs007 @sre-ci-robot @yanliang567