Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug that set incorrect info to columnbase #34621

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

zhagnlu
Copy link
Collaborator

@zhagnlu zhagnlu commented Jul 11, 2024

pr: #34428

Signed-off-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 11, 2024
@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Jul 12, 2024

rerun ut

@mergify mergify bot added the ci-passed label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.73%. Comparing base (f6cd841) to head (2f345a4).
Report is 23 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34621       +/-   ##
===========================================
- Coverage   80.76%   69.73%   -11.04%     
===========================================
  Files        1051     1046        -5     
  Lines      135826   136194      +368     
===========================================
- Hits       109705    94980    -14725     
- Misses      21916    36999    +15083     
- Partials     4205     4215       +10     
Files Coverage Δ
internal/core/src/common/FieldMeta.h 0.00% <0.00%> (-100.00%) ⬇️
internal/core/src/mmap/Column.h 0.00% <0.00%> (-81.95%) ⬇️

... and 311 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 91952e8 into milvus-io:2.4 Jul 12, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants