fix: fix bug that set incorrect info to columnbase #34428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@zhagnlu E2e jenkins job failed, comment |
zhagnlu
force-pushed
the
fix_column_bug
branch
3 times, most recently
from
e7a5c7c
to
97a7c31
Compare
|
rerun ut |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34428 +/- ##
==========================================
- Coverage 84.35% 80.68% -3.67%
==========================================
Files 858 1122 +264
Lines 115248 139768 +24520
==========================================
+ Hits 97212 112766 +15554
- Misses 13734 22706 +8972
+ Partials 4302 4296 -6
|
Signed-off-by: luzhang <luzhang@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 12, 2024
pr: #34428 Signed-off-by: luzhang <luzhang@zilliz.com> Co-authored-by: luzhang <luzhang@zilliz.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, zhagnlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34427