-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft]feat: support alter collection field properties #34963
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PowderLi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@PowderLi Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@PowderLi E2e jenkins job failed, comment |
80602ad
to
9d54c67
Compare
@PowderLi E2e jenkins job failed, comment |
9d54c67
to
182415a
Compare
@PowderLi E2e jenkins job failed, comment |
182415a
to
94f5e03
Compare
@@ -1218,13 +1218,25 @@ func (node *Proxy) ShowCollections(ctx context.Context, request *milvuspb.ShowCo | |||
} | |||
|
|||
func (node *Proxy) AlterCollection(ctx context.Context, request *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) { | |||
return node.alterCollectionOrField(ctx, "AlterCollection", &milvuspb.AlterCollectionRequest{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be simplified to node.alterCollectionOrField(ctx, "AlterCollection", request)
.
@@ -1250,6 +1250,17 @@ func (c *Core) ShowCollections(ctx context.Context, in *milvuspb.ShowCollections | |||
} | |||
|
|||
func (c *Core) AlterCollection(ctx context.Context, in *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) { | |||
return c.AlterCollectionOrField(ctx, &milvuspb.AlterCollectionRequest{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be simplified to c.AlterCollectionOrField(ctx, in)
.
lgtm |
Signed-off-by: PowderLi <min.li@zilliz.com>
94f5e03
to
cff7038
Compare
@PowderLi E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34963 +/- ##
==========================================
+ Coverage 71.81% 80.99% +9.17%
==========================================
Files 1184 1189 +5
Lines 143767 143468 -299
==========================================
+ Hits 103246 116199 +12953
+ Misses 36107 22851 -13256
- Partials 4414 4418 +4
|
issue: #34646