Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: IndexNode do not support MINIO_ACCESS_KEY Environment variable #9706

Closed
1 task done
zwd1208 opened this issue Oct 12, 2021 · 5 comments · Fixed by #10534
Closed
1 task done

[Bug]: IndexNode do not support MINIO_ACCESS_KEY Environment variable #9706

zwd1208 opened this issue Oct 12, 2021 · 5 comments · Fixed by #10534
Assignees
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@zwd1208
Copy link
Contributor

zwd1208 commented Oct 12, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I use MINIO_ACCESS_KEY and MINIO_SECRET_KEY environment variables to configure minio for indexnode,but the indexnode logs shows it still use the config file, so indexnode finally can't access the minio

The following shows the log:
[2021/10/11 11:50:38.215 +00:00] [DEBUG] [indexnode.go:107] ["IndexNode try connect etcd success"]
[2021/10/11 11:50:38.215 +00:00] [DEBUG] [minio_kv.go:47] ["MinioKV NewMinioKV"] [option="{"Address":"my-release-minio.default:9000","AccessKeyID":"","BucketName":"my-release","SecretAccessKeyID":"","UseSSL":false,"CreateBucket":true}"]
[2021/10/11 11:50:38.218 +00:00] [INFO] [grpclog.go:37] ["[core]Subchannel picks a new address "my-release-etcd.default:2379" to connect"]
[2021/10/11 11:50:38.215 +00:00] [INFO] [grpclog.go:37] ["[balancer]base.baseBalancer: handle SubConn state change: 0xc0001cf610, CONNECTING"]
[2021/10/11 11:50:38.219 +00:00] [INFO] [grpclog.go:37] ["[core]Channel Connectivity change to CONNECTING"]
[2021/10/11 11:50:38.250 +00:00] [INFO] [grpclog.go:37] ["[core]Subchannel Connectivity change to READY"]
[2021/10/11 11:50:38.250 +00:00] [INFO] [grpclog.go:37] ["[balancer]base.baseBalancer: handle SubConn state change: 0xc0001cf610, READY"]
[2021/10/11 11:50:38.250 +00:00] [INFO] [grpclog.go:37] ["[roundrobin]roundrobinPicker: newPicker called with info: {map[0xc0001cf610:{{my-release-etcd.default:2379 my-release-etcd.default 0 }}]}"]
[2021/10/11 11:50:38.250 +00:00] [INFO] [grpclog.go:37] ["[core]Channel Connectivity change to READY"]
[2021/10/11 12:05:29.884 +00:00] [DEBUG] [indexnode.go:119] ["IndexNode NewMinIOKV failed"] [error="All attempts results:\nattempt #1:Access Denied.\nattempt #2:Access Denied.\nattempt #3:Access Denied.\nattempt #4:Access Denied.\nattempt #5:Access Denied.\nattempt #6:Access D

Expected Behavior

IndexNode should support read the minio access key and secret from environment variables

Steps To Reproduce

config the env in IndexNode deployment:
env:
- name: MINIO_ACCESS_KEY
  valueFrom:
    secretKeyRef:
      key: access-key
      name: my-release-minio
- name: MINIO_SECRET_KEY
  valueFrom:
    secretKeyRef:
      key: secret-key
      name: my-release-minio

Environment

- Milvus version: v2.0.0-rc6-20210910-020f109
- Deployment mode(standalone or cluster): cluster
- SDK version(e.g. pymilvus v2.0.0rc2): 
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Anything else?

No response

@zwd1208 zwd1208 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 12, 2021
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 12, 2021
@yanliang567 yanliang567 added this to the 2.0-Backlog milestone Oct 12, 2021
@yanliang567
Copy link
Contributor

/assign @bigsheeper

/unassign

@bigsheeper
Copy link
Contributor

/assign @xiaocai2333
/unassign

@xiaocai2333
Copy link
Contributor

/reopen
/assign @zwd1208

@sre-ci-robot
Copy link
Contributor

@xiaocai2333: Reopened this issue.

In response to this:

/reopen
/assign @zwd1208

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot sre-ci-robot reopened this Oct 26, 2021
@xiaocai2333 xiaocai2333 removed their assignment Oct 26, 2021
@stale
Copy link

stale bot commented Nov 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 25, 2021
@stale stale bot closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants