Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiSave childTask failed to etcd #10340

Merged
merged 1 commit into from Oct 21, 2021

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Oct 21, 2021

fix issue: #9787
Signed-off-by: xige-16 xi.ge@zilliz.com

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 21, 2021
Signed-off-by: xige-16 <xi.ge@zilliz.com>
@xiaofan-luan
Copy link
Contributor

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #10340 (4f216a0) into master (f940825) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10340      +/-   ##
==========================================
+ Coverage   78.95%   78.98%   +0.03%     
==========================================
  Files         437      437              
  Lines       54572    54579       +7     
==========================================
+ Hits        43087    43110      +23     
+ Misses       9319     9309      -10     
+ Partials     2166     2160       -6     
Impacted Files Coverage Δ
internal/querycoord/task_scheduler.go 75.00% <100.00%> (+0.26%) ⬆️
internal/rootcoord/proxy_manager.go 78.22% <0.00%> (-3.23%) ⬇️
internal/querycoord/querynode.go 66.39% <0.00%> (-1.64%) ⬇️
internal/querycoord/query_coord.go 76.25% <0.00%> (-1.37%) ⬇️
internal/indexnode/indexnode.go 89.95% <0.00%> (-1.21%) ⬇️
internal/msgstream/mq_msgstream.go 78.21% <0.00%> (-0.88%) ⬇️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 75.41% <0.00%> (+0.16%) ⬆️
internal/datanode/data_node.go 84.59% <0.00%> (+0.61%) ⬆️
internal/util/flowgraph/node.go 73.39% <0.00%> (+0.91%) ⬆️
... and 5 more

@mergify mergify bot added the ci-passed label Oct 21, 2021
@sre-ci-robot sre-ci-robot merged commit f68a335 into milvus-io:master Oct 21, 2021
@xige-16 xige-16 deleted the fix-multi-save-loadreq branch December 6, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants