Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load segment request too large #10812

Merged
merged 1 commit into from Oct 28, 2021
Merged

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Oct 28, 2021

fix issue: #10743
Signed-off-by: xige-16 xi.ge@zilliz.com

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #10812 (6b0e202) into master (921ef0f) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10812      +/-   ##
==========================================
- Coverage   79.59%   79.46%   -0.13%     
==========================================
  Files         429      429              
  Lines       55559    55575      +16     
==========================================
- Hits        44221    44164      -57     
- Misses       9108     9168      +60     
- Partials     2230     2243      +13     
Impacted Files Coverage Δ
internal/querynode/collection_replica.go 84.83% <ø> (ø)
internal/querycoord/task.go 85.93% <100.00%> (-0.21%) ⬇️
internal/querycoord/task_scheduler.go 77.66% <100.00%> (+0.29%) ⬆️
internal/proxy/timestamp.go 77.50% <0.00%> (-15.00%) ⬇️
...knowhere/index/vector_index/impl/nsg/NSGHelper.cpp 72.72% <0.00%> (-9.10%) ⬇️
internal/indexnode/indexnode_mock.go 82.17% <0.00%> (-5.45%) ⬇️
internal/proxy/channels_time_ticker.go 75.60% <0.00%> (-4.27%) ⬇️
internal/distributed/rootcoord/client/client.go 91.54% <0.00%> (-4.23%) ⬇️
internal/datacoord/segment_manager.go 82.62% <0.00%> (-2.84%) ⬇️
internal/rootcoord/timeticksync.go 93.02% <0.00%> (-2.80%) ⬇️
... and 12 more

@mergify mergify bot added the ci-passed label Oct 28, 2021
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6d43ac4 into milvus-io:master Oct 28, 2021
@xige-16 xige-16 deleted the test branch December 6, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants