Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ReportImport related logic. #16225

Closed

Conversation

soothing-rain
Copy link
Contributor

@soothing-rain soothing-rain commented Mar 28, 2022

Upon receiving ReportImport request, rootcoord will do the following:

  1. Update the import task status in Etcd.
  2. Start watch indexing building status of the segments created by this task. When all indices are built for these segments, rootcoord will mark these segments "ready to go online".

/kind feature

issue: #15604

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/feature Issues related to feature request from users label Mar 28, 2022
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 28, 2022
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Mar 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2022

@soothing-rain E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #16225 (a62d3ba) into master (40c703d) will decrease coverage by 0.14%.
The diff coverage is 59.12%.

❗ Current head a62d3ba differs from pull request most recent head efb35fe. Consider uploading reports for the commit efb35fe to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16225      +/-   ##
==========================================
- Coverage   81.03%   80.89%   -0.15%     
==========================================
  Files         411      413       +2     
  Lines       61940    62384     +444     
==========================================
+ Hits        50196    50463     +267     
- Misses       9366     9517     +151     
- Partials     2378     2404      +26     
Impacted Files Coverage Δ
internal/querycoord/cluster.go 79.04% <0.00%> (-0.69%) ⬇️
internal/rootcoord/timeticksync.go 90.25% <ø> (ø)
internal/querycoord/meta.go 76.31% <3.77%> (-1.30%) ⬇️
internal/querycoord/replica.go 13.95% <13.95%> (ø)
internal/rootcoord/import_manager.go 85.17% <88.99%> (+0.92%) ⬆️
internal/rootcoord/root_coord.go 80.43% <95.00%> (+0.80%) ⬆️
...nternal/querynode/flow_graph_filter_delete_node.go 82.89% <0.00%> (-5.27%) ⬇️
internal/kv/mem/mem_kv.go 72.76% <0.00%> (-4.88%) ⬇️
internal/querynode/flow_graph_delete_node.go 81.25% <0.00%> (-4.17%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 76.03% <0.00%> (-4.14%) ⬇️
... and 23 more

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-issue and removed needs-dco DCO is missing in this pull request. labels Mar 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2022

@soothing-rain Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2022

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

@soothing-rain
Copy link
Contributor Author

rerun ut

@yhmo
Copy link
Contributor

yhmo commented Mar 29, 2022

/lgtm

@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

@soothing-rain, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Mar 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soothing-rain

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Mar 29, 2022
@mergify mergify bot added the ci-passed label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users needs-rebase size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants