Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report bulk load state #16555

Merged
merged 1 commit into from Apr 21, 2022
Merged

Report bulk load state #16555

merged 1 commit into from Apr 21, 2022

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented Apr 20, 2022

Signed-off-by: groot yihua.mo@zilliz.com

#15604

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 20, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Apr 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

@yhmo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@yhmo yhmo added the do-not-merge/work-in-progress Don't merge even CI passed. label Apr 20, 2022
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Apr 20, 2022
@yhmo yhmo requested review from soothing-rain and removed request for cydrain and longjiquan April 20, 2022 10:12
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

@yhmo ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

@yhmo ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

@yhmo E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #16555 (f32f376) into master (f93862f) will decrease coverage by 0.04%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16555      +/-   ##
==========================================
- Coverage   80.61%   80.57%   -0.05%     
==========================================
  Files         437      437              
  Lines       68402    68481      +79     
==========================================
+ Hits        55143    55177      +34     
- Misses      10629    10673      +44     
- Partials     2630     2631       +1     
Impacted Files Coverage Δ
internal/util/importutil/numpy_parser.go 80.09% <70.00%> (-1.20%) ⬇️
internal/util/importutil/json_handler.go 84.90% <75.00%> (-0.08%) ⬇️
internal/util/importutil/import_wrapper.go 86.33% <83.82%> (+3.15%) ⬆️
internal/datanode/data_node.go 80.05% <100.00%> (+3.00%) ⬆️
internal/rootcoord/import_manager.go 87.69% <100.00%> (-0.76%) ⬇️
...nternal/querynode/flow_graph_filter_delete_node.go 80.51% <0.00%> (-5.20%) ⬇️
internal/querynode/query_collection.go 70.94% <0.00%> (-4.34%) ⬇️
internal/querynode/flow_graph_delete_node.go 81.25% <0.00%> (-4.17%) ⬇️
internal/distributed/querycoord/client/client.go 69.95% <0.00%> (-1.98%) ⬇️
internal/indexnode/task.go 64.84% <0.00%> (-1.31%) ⬇️
... and 18 more

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

@yhmo ut workflow job failed, comment rerun ut can trigger the job again.

@yhmo yhmo changed the title Repor bulk load state Report bulk load state Apr 20, 2022
@@ -36,12 +36,13 @@ services:
image: minio/minio:RELEASE.2022-03-17T06-34-49Z
ports:
- "9000:9000"
- "9001:9001"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LoveEachDay can you take a look at this?

Also please update docker-compose-apple-silicon.yml as well.

@soothing-rain
Copy link
Contributor

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

@yhmo ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

@yhmo E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

@yhmo ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

@yhmo E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

@yhmo ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

@yhmo E2e jenkins job failed, comment /run-checks can trigger the job again.

Signed-off-by: groot <yihua.mo@zilliz.com>
@jennyli-z
Copy link
Contributor

rerun ut

1 similar comment
@jennyli-z
Copy link
Contributor

rerun ut

@mergify mergify bot added the ci-passed label Apr 21, 2022
@soothing-rain
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a6a3b69 into milvus-io:master Apr 21, 2022
@yhmo yhmo deleted the main branch April 22, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants