Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve an issue with bulk load with "DataNode abnormal" #16609

Merged
merged 1 commit into from Apr 25, 2022

Conversation

soothing-rain
Copy link
Contributor

Resolve an issue with bulk load where segments in flow graph replica are not updated

issue: #15604

/kind enhancement

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/enhancement Issues or changes related to enhancement label Apr 24, 2022
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Apr 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2022

@soothing-rain, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added dco-passed DCO check passed. needs-rebase labels Apr 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2022

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #16609 (e0380cb) into master (242f08f) will increase coverage by 0.18%.
The diff coverage is 87.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16609      +/-   ##
==========================================
+ Coverage   80.55%   80.73%   +0.18%     
==========================================
  Files         437      437              
  Lines       68504    68989     +485     
==========================================
+ Hits        55183    55698     +515     
+ Misses      10686    10643      -43     
- Partials     2635     2648      +13     
Impacted Files Coverage Δ
internal/datacoord/services.go 87.45% <42.85%> (-0.28%) ⬇️
internal/rootcoord/root_coord.go 77.89% <68.42%> (-0.08%) ⬇️
internal/datacoord/segment_manager.go 83.05% <85.71%> (+0.23%) ⬆️
internal/datacoord/cluster.go 95.34% <100.00%> (+0.16%) ⬆️
internal/datacoord/server.go 73.39% <100.00%> (+0.10%) ⬆️
internal/datanode/data_node.go 80.85% <100.00%> (+0.77%) ⬆️
internal/datanode/flow_graph_insert_buffer_node.go 86.66% <100.00%> (ø)
internal/util/funcutil/parallel.go 95.77% <0.00%> (-4.23%) ⬇️
internal/querynode/query_channel.go 39.74% <0.00%> (-3.85%) ⬇️
internal/proxy/plan_parser.go 81.75% <0.00%> (-1.49%) ⬇️
... and 35 more

@yhmo
Copy link
Contributor

yhmo commented Apr 24, 2022

/lgtm

…are not updated

issue: milvus-io#15604

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2022

@soothing-rain E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2022

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

@soothing-rain
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Apr 24, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, soothing-rain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e66ac6a into milvus-io:master Apr 25, 2022
@soothing-rain soothing-rain deleted the abnormal branch April 25, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants