Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load binlog for different field in parallel #17005

Merged
merged 1 commit into from May 15, 2022

Conversation

xiaofan-luan
Copy link
Contributor

@xiaofan-luan xiaofan-luan commented May 15, 2022

fix #17004
Signed-off-by: xiaofan-luan xiaofan.luan@zilliz.com

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
@xiaofan-luan xiaofan-luan added the kind/feature Issues related to feature request from users label May 15, 2022
@xiaofan-luan xiaofan-luan requested a review from yah01 May 15, 2022 04:20
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 15, 2022
@mergify mergify bot added the dco-passed DCO check passed. label May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #17005 (65c56f5) into master (328ab7e) will increase coverage by 0.10%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17005      +/-   ##
==========================================
+ Coverage   81.15%   81.26%   +0.10%     
==========================================
  Files         456      456              
  Lines       72712    72710       -2     
==========================================
+ Hits        59011    59086      +75     
+ Misses      10966    10890      -76     
+ Partials     2735     2734       -1     
Impacted Files Coverage Δ
internal/querynode/segment_loader.go 68.98% <89.47%> (+0.39%) ⬆️
internal/kv/rocksdb/RocksIterator.go 72.09% <0.00%> (-6.98%) ⬇️
internal/rootcoord/task.go 78.15% <0.00%> (-1.18%) ⬇️
internal/datacoord/server.go 73.39% <0.00%> (-0.78%) ⬇️
internal/rootcoord/meta_table.go 82.08% <0.00%> (-0.49%) ⬇️
internal/rootcoord/root_coord.go 80.78% <0.00%> (-0.23%) ⬇️
internal/indexcoord/index_coord.go 78.33% <0.00%> (ø)
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (ø)
internal/proxy/task.go 81.61% <0.00%> (+0.12%) ⬆️
... and 13 more

@mergify mergify bot added the ci-passed label May 15, 2022
@yah01
Copy link
Member

yah01 commented May 15, 2022

/lgtm
Thanks xiaofan! It seems that I removed the code of loading fields in parallel when resolving conflicts...
We may reach the better by: to deserialize fields in parallel, this works for sealed segments, I will implement that later

@sre-ci-robot sre-ci-robot merged commit 338edcd into milvus-io:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Segment loader load different field in parallel
3 participants