Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default seal propotion #17287

Merged
merged 1 commit into from May 31, 2022

Conversation

longjiquan
Copy link
Contributor

Signed-off-by: dragondriver jiquan.long@zilliz.com
/kind improvement

Signed-off-by: dragondriver <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 31, 2022
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 31, 2022
@mergify mergify bot added the dco-passed DCO check passed. label May 31, 2022
@longjiquan
Copy link
Contributor Author

/cc @xiaofan-luan @congqixia @czs007

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #17287 (88d2158) into master (9ce9c6e) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17287      +/-   ##
==========================================
- Coverage   80.72%   80.68%   -0.05%     
==========================================
  Files         462      462              
  Lines       72187    72187              
==========================================
- Hits        58275    58244      -31     
- Misses      11305    11333      +28     
- Partials     2607     2610       +3     
Impacted Files Coverage Δ
internal/util/paramtable/component_param.go 88.79% <100.00%> (ø)
internal/proxy/channels_time_ticker.go 75.37% <0.00%> (-5.23%) ⬇️
internal/indexcoord/node_manager.go 70.42% <0.00%> (-4.93%) ⬇️
internal/indexcoord/index_coord.go 76.90% <0.00%> (-2.73%) ⬇️
internal/util/funcutil/parallel.go 43.50% <0.00%> (-1.95%) ⬇️
internal/proxy/proxy.go 63.81% <0.00%> (-1.95%) ⬇️
internal/indexnode/indexnode_mock.go 86.69% <0.00%> (-1.15%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 79.66% <0.00%> (-0.85%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.80% <0.00%> (-0.59%) ⬇️
internal/querycoord/task.go 76.45% <0.00%> (-0.51%) ⬇️
... and 6 more

@mergify mergify bot added the ci-passed label May 31, 2022
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longjiquan, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6bd786b into milvus-io:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants