Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace faiss::MetricType with knowhere::MetricType #17891

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jun 29, 2022

Signed-off-by: yudong.cai yudong.cai@zilliz.com
Issue: #17599 #17890

@mergify mergify bot added the dco-passed DCO check passed. label Jun 29, 2022
@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Jun 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_use_knowhere_metric_type branch from 94328f3 to 85c9cc0 Compare June 29, 2022 03:29
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2022

@cydrain E2e jenkins job failed, comment /run-checks can trigger the job again.

@longjiquan
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #17891 (85c9cc0) into master (6b79d4f) will increase coverage by 0.00%.
The diff coverage is 80.76%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17891   +/-   ##
=======================================
  Coverage   81.11%   81.11%           
=======================================
  Files         472      472           
  Lines       74955    74927   -28     
=======================================
- Hits        60796    60780   -16     
+ Misses      11480    11469   -11     
+ Partials     2679     2678    -1     
Impacted Files Coverage Δ
internal/core/src/indexbuilder/VecIndexCreator.h 100.00% <ø> (ø)
internal/core/src/query/PlanNode.h 100.00% <ø> (ø)
internal/core/src/query/PlanProto.cpp 86.28% <ø> (ø)
internal/core/src/query/helper.h 100.00% <ø> (ø)
...al/core/src/query/visitors/ShowPlanNodeVisitor.cpp 85.71% <ø> (-1.25%) ⬇️
internal/core/src/segcore/plan_c.cpp 60.00% <ø> (-0.61%) ⬇️
internal/core/src/query/SearchBruteForce.cpp 72.34% <44.44%> (-2.66%) ⬇️
internal/core/src/common/FieldMeta.h 83.33% <100.00%> (ø)
internal/core/src/common/Schema.cpp 75.00% <100.00%> (ø)
internal/core/src/common/Schema.h 90.24% <100.00%> (ø)
... and 45 more

@mergify mergify bot added the ci-passed label Jun 29, 2022
@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a001412 into milvus-io:master Jun 29, 2022
@cydrain cydrain deleted the caiyd_use_knowhere_metric_type branch June 29, 2022 06:23
@mergify mergify bot removed the ci-passed label Aug 13, 2022
cydrain added a commit to cydrain/milvus that referenced this pull request Sep 1, 2022
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants