Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API for searching on sealed segment without index #18830

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Aug 25, 2022

Signed-off-by: yudong.cai yudong.cai@zilliz.com
Issue: #17599 #17945

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 25, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 25, 2022
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_17599_update_search_on_sealed branch from 505fe39 to 7fa1ace Compare August 25, 2022 08:40
@cydrain cydrain changed the title Add API SearchOnSealedChunk() to search on sealed segment without index Add new API for searching on sealed segment without index Aug 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2022

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain
Copy link
Contributor Author

cydrain commented Aug 25, 2022

/run-cpu-e2e

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #18830 (7fa1ace) into master (dcf45df) will increase coverage by 0.03%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18830      +/-   ##
==========================================
+ Coverage   81.33%   81.36%   +0.03%     
==========================================
  Files         542      542              
  Lines       81261    81264       +3     
==========================================
+ Hits        66095    66124      +29     
+ Misses      12293    12270      -23     
+ Partials     2873     2870       -3     
Impacted Files Coverage Δ
internal/core/src/segcore/SegmentGrowingImpl.cpp 78.28% <0.00%> (ø)
internal/core/src/query/SearchOnSealed.cpp 94.11% <100.00%> (+2.22%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 77.32% <100.00%> (-0.37%) ⬇️
internal/config/etcd_source.go 71.73% <0.00%> (-3.27%) ⬇️
internal/datacoord/segment_manager.go 82.82% <0.00%> (-1.39%) ⬇️
internal/datacoord/server.go 76.14% <0.00%> (-0.66%) ⬇️
internal/indexcoord/meta_table.go 65.28% <0.00%> (-0.27%) ⬇️
internal/proxy/impl.go 91.04% <0.00%> (+0.45%) ⬆️
internal/querycoord/query_coord.go 77.38% <0.00%> (+0.56%) ⬆️
... and 6 more

@mergify mergify bot added the ci-passed label Aug 25, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 305601a into milvus-io:master Aug 25, 2022
@cydrain cydrain deleted the caiyd_17599_update_search_on_sealed branch August 25, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants