Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of slice_nqs and slice_topks from int32_t[] to int64_t[] #18867

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Aug 28, 2022

Signed-off-by: yudong.cai yudong.cai@zilliz.com
Issue: #17599

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 28, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

@cydrain cydrain force-pushed the caiyd_17599_opt_slice_nq_type branch from 8bae9d5 to 71faa26 Compare August 28, 2022 04:52
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

@cydrain cydrain force-pushed the caiyd_17599_opt_slice_nq_type branch from 71faa26 to 053958a Compare August 28, 2022 15:50
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2022

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

@cydrain
Copy link
Contributor Author

cydrain commented Aug 29, 2022

/run-cpu-e2e

@cydrain
Copy link
Contributor Author

cydrain commented Aug 29, 2022

rerun ut

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_17599_opt_slice_nq_type branch from 053958a to b219652 Compare August 29, 2022 02:25
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #18867 (b219652) into master (c4a9e13) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18867   +/-   ##
=======================================
  Coverage   81.41%   81.42%           
=======================================
  Files         539      539           
  Lines       81205    81201    -4     
=======================================
  Hits        66117    66117           
+ Misses      12232    12226    -6     
- Partials     2856     2858    +2     
Impacted Files Coverage Δ
internal/core/src/segcore/Reduce.h 100.00% <100.00%> (ø)
internal/core/src/segcore/reduce_c.cpp 72.72% <100.00%> (-5.06%) ⬇️
internal/querynode/reduce.go 63.63% <100.00%> (ø)
internal/distributed/indexcoord/client/client.go 51.23% <0.00%> (-4.33%) ⬇️
internal/util/timerecord/group_checker.go 95.74% <0.00%> (-4.26%) ⬇️
internal/querycoord/group_balance.go 67.30% <0.00%> (-3.85%) ⬇️
internal/querycoord/task_scheduler.go 78.57% <0.00%> (-0.81%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.89% <0.00%> (-0.29%) ⬇️
internal/indexcoord/meta_table.go 65.28% <0.00%> (-0.27%) ⬇️
internal/querycoord/task.go 77.70% <0.00%> (+0.05%) ⬆️
... and 7 more

@mergify mergify bot added the ci-passed label Aug 29, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9dc3bbe into milvus-io:master Aug 29, 2022
@cydrain cydrain deleted the caiyd_17599_opt_slice_nq_type branch August 29, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants