Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize segcore Reduce #18902

Merged
merged 1 commit into from Sep 6, 2022

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Aug 30, 2022

Signed-off-by: yudong.cai yudong.cai@zilliz.com
Issue: #17599

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 30, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #18902 (026664c) into master (ff5201c) will increase coverage by 0.00%.
The diff coverage is 98.97%.

❗ Current head 026664c differs from pull request most recent head ec7555e. Consider uploading reports for the commit ec7555e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18902   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files         540      540           
  Lines       81713    81713           
=======================================
+ Hits        66372    66375    +3     
+ Misses      12494    12489    -5     
- Partials     2847     2849    +2     
Impacted Files Coverage Δ
internal/core/src/segcore/Reduce.h 100.00% <ø> (ø)
internal/core/src/segcore/Reduce.cpp 94.04% <98.97%> (ø)
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-4.24%) ⬇️
internal/datacoord/server.go 76.18% <0.00%> (-0.66%) ⬇️
internal/querycoord/task.go 77.45% <0.00%> (-0.59%) ⬇️
internal/datanode/compactor.go 90.94% <0.00%> (ø)
internal/util/grpcclient/client.go 94.37% <0.00%> (ø)
internal/rootcoord/root_coord.go 75.33% <0.00%> (+0.09%) ⬆️
internal/indexcoord/meta_table.go 76.64% <0.00%> (+0.27%) ⬆️
... and 4 more

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

@cydrain cydrain force-pushed the caiyd_17599_opt_reduce branch 3 times, most recently from 8fe95c9 to 63d4fa3 Compare August 30, 2022 09:43
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

@cydrain
Copy link
Contributor Author

cydrain commented Aug 30, 2022

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

@cydrain
Copy link
Contributor Author

cydrain commented Aug 30, 2022

rerun ut

@mergify mergify bot added ci-passed and removed ci-passed labels Aug 30, 2022
@cydrain
Copy link
Contributor Author

cydrain commented Sep 1, 2022

/hold

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2022

@cydrain, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Sep 2, 2022
@mergify mergify bot removed the needs-rebase label Sep 2, 2022
@cydrain cydrain changed the title Optimize segcore Reduce interface Refactor segcore Reduce Sep 2, 2022
@cydrain cydrain changed the title Refactor segcore Reduce Optimize segcore Reduce Sep 2, 2022
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2022

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@Presburger
Copy link
Contributor

/lgtm

@cydrain
Copy link
Contributor Author

cydrain commented Sep 6, 2022

/unhold
/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor and removed do-not-merge/hold labels Sep 6, 2022
@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 765907a into milvus-io:master Sep 6, 2022
@cydrain cydrain deleted the caiyd_17599_opt_reduce branch September 6, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants