Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip e2e] Optimize test_reduce #18957

Merged
merged 1 commit into from Sep 1, 2022

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Sep 1, 2022

Signed-off-by: yudong.cai yudong.cai@zilliz.com
Issue: #17599

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 1, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Sep 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2022

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #18957 (777baa7) into master (0e4e796) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18957      +/-   ##
==========================================
+ Coverage   81.19%   81.20%   +0.01%     
==========================================
  Files         540      540              
  Lines       81581    81581              
==========================================
+ Hits        66242    66251       +9     
+ Misses      12487    12480       -7     
+ Partials     2852     2850       -2     
Impacted Files Coverage Δ
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-2.55%) ⬇️
internal/proxy/util.go 87.52% <0.00%> (-0.59%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.17% <0.00%> (-0.15%) ⬇️
internal/datacoord/server.go 76.79% <0.00%> (+0.65%) ⬆️
internal/datacoord/segment_manager.go 84.21% <0.00%> (+1.38%) ⬆️
internal/proxy/segment.go 89.39% <0.00%> (+1.51%) ⬆️
internal/proxy/channels_time_ticker.go 82.83% <0.00%> (+2.23%) ⬆️

@congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 1, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4ded453 into milvus-io:master Sep 1, 2022
@cydrain cydrain deleted the caiyd_update_reduce_ut branch September 1, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants