New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fill the string field twice when string index exists #21852
Conversation
Also the filling is not efficient for string type, as it needs to read and deserialize the same binlog many times |
Codecov Report
@@ Coverage Diff @@
## master #21852 +/- ##
==========================================
+ Coverage 82.36% 82.39% +0.03%
==========================================
Files 694 694
Lines 93577 93578 +1
==========================================
+ Hits 77074 77108 +34
+ Misses 13640 13610 -30
+ Partials 2863 2860 -3
|
/run-cpu-e2e |
Signed-off-by: yah01 <yang.cen@zilliz.com>
a259e1f
to
a8d8403
Compare
/kind improvement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…1852) Signed-off-by: yah01 <yang.cen@zilliz.com>
Signed-off-by: yah01 yang.cen@zilliz.com
related #20765
For scalar index, we have retrieved the field data from index, re-fill would cause much performance downgrade