Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fill the string field twice when string index exists #21852

Merged
merged 1 commit into from Jan 29, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jan 29, 2023

Signed-off-by: yah01 yang.cen@zilliz.com
related #20765
For scalar index, we have retrieved the field data from index, re-fill would cause much performance downgrade

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 29, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jan 29, 2023
@yah01
Copy link
Member Author

yah01 commented Jan 29, 2023

Also the filling is not efficient for string type, as it needs to read and deserialize the same binlog many times

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #21852 (a8d8403) into master (09124f8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21852      +/-   ##
==========================================
+ Coverage   82.36%   82.39%   +0.03%     
==========================================
  Files         694      694              
  Lines       93577    93578       +1     
==========================================
+ Hits        77074    77108      +34     
+ Misses      13640    13610      -30     
+ Partials     2863     2860       -3     
Impacted Files Coverage Δ
internal/querynode/segment.go 81.65% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/job/scheduler.go 88.42% <0.00%> (-6.32%) ⬇️
internal/datacoord/session_manager.go 83.24% <0.00%> (-2.54%) ⬇️
internal/mq/msgstream/mq_msgstream.go 77.66% <0.00%> (-1.81%) ⬇️
internal/querycoordv2/checkers/segment_checker.go 85.41% <0.00%> (-1.57%) ⬇️
internal/distributed/querycoord/client/client.go 79.09% <0.00%> (-1.40%) ⬇️
internal/proxy/meta_cache.go 86.65% <0.00%> (-0.94%) ⬇️
internal/rootcoord/quota_center.go 85.59% <0.00%> (-0.64%) ⬇️
internal/proxy/impl.go 88.96% <0.00%> (+0.32%) ⬆️
internal/indexnode/task.go 50.92% <0.00%> (+0.53%) ⬆️
... and 9 more

@yah01
Copy link
Member Author

yah01 commented Jan 29, 2023

/run-cpu-e2e

Signed-off-by: yah01 <yang.cen@zilliz.com>
@congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jan 29, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants