Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search task merge policy #22006

Merged
merged 1 commit into from Feb 7, 2023
Merged

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Feb 6, 2023

Signed-off-by: yah01 yang.cen@zilliz.com
/kind improvement
fix #22005

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 6, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 6, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #22006 (4400614) into master (ffdb652) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22006      +/-   ##
==========================================
+ Coverage   82.25%   82.32%   +0.06%     
==========================================
  Files         698      698              
  Lines       95343    95346       +3     
==========================================
+ Hits        78427    78492      +65     
+ Misses      13956    13891      -65     
- Partials     2960     2963       +3     
Impacted Files Coverage Δ
internal/querynode/task_search.go 35.89% <100.00%> (+6.12%) ⬆️
internal/datacoord/segment_manager.go 86.98% <0.00%> (-2.22%) ⬇️
internal/datacoord/server.go 71.77% <0.00%> (-1.76%) ⬇️
internal/querynode/shard_cluster.go 95.88% <0.00%> (+0.39%) ⬆️
internal/datacoord/session_manager.go 83.75% <0.00%> (+0.50%) ⬆️
internal/distributed/datacoord/client/client.go 74.36% <0.00%> (+0.72%) ⬆️
internal/mq/msgstream/mq_msgstream.go 79.31% <0.00%> (+0.82%) ⬆️
internal/distributed/querycoord/client/client.go 80.37% <0.00%> (+1.06%) ⬆️
internal/rootcoord/quota_center.go 86.86% <0.00%> (+1.27%) ⬆️
internal/querycoordv2/session/cluster.go 70.04% <0.00%> (+1.44%) ⬆️
... and 7 more

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 6, 2023
Signed-off-by: yah01 <yang.cen@zilliz.com>
@congqixia
Copy link
Contributor

/cc @czs007

@czs007
Copy link
Contributor

czs007 commented Feb 7, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5abb8a0 into milvus-io:master Feb 7, 2023
yah01 added a commit to yah01/milvus that referenced this pull request Feb 20, 2023
Signed-off-by: yah01 <yang.cen@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Feb 20, 2023
Signed-off-by: yah01 <yang.cen@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: May merge search tasks to break TopKMergeRatio
4 participants