New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DiskANN can't recovery after querynode reboots #22488
Conversation
Could you add a UT or e2e test to cover this case? |
Signed-off-by: yah01 <yang.cen@zilliz.com>
e2e can't cover this because we can't to create such a dir, for now DiskANN unittest can't run due to we need to enable DiskANN with compile option "disk_index=ON" |
@yah01 ut workflow job failed, comment |
rerun ut |
Codecov Report
@@ Coverage Diff @@
## master #22488 +/- ##
==========================================
- Coverage 82.54% 82.25% -0.30%
==========================================
Files 706 707 +1
Lines 96549 98198 +1649
==========================================
+ Hits 79696 80770 +1074
- Misses 13882 14457 +575
Partials 2971 2971
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiaoew1991, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yah01 <yang.cen@zilliz.com>
/kind bug
related #22460
Also fix missing to throw exception when failed to remove dir