Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DiskANN can't recovery after querynode reboots #22488

Merged
merged 1 commit into from Mar 2, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Mar 1, 2023

/kind bug
related #22460
Also fix missing to throw exception when failed to remove dir

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Mar 1, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 1, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Mar 1, 2023
@jiaoew1991
Copy link
Contributor

Could you add a UT or e2e test to cover this case?

Signed-off-by: yah01 <yang.cen@zilliz.com>
@yah01
Copy link
Member Author

yah01 commented Mar 1, 2023

Could you add a UT or e2e test to cover this case?

e2e can't cover this because we can't to create such a dir, for now DiskANN unittest can't run due to we need to enable DiskANN with compile option "disk_index=ON"

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Mar 1, 2023

rerun ut

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #22488 (b3a73f3) into master (fa5c339) will decrease coverage by 0.30%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22488      +/-   ##
==========================================
- Coverage   82.54%   82.25%   -0.30%     
==========================================
  Files         706      707       +1     
  Lines       96549    98198    +1649     
==========================================
+ Hits        79696    80770    +1074     
- Misses      13882    14457     +575     
  Partials     2971     2971              
Impacted Files Coverage Δ
internal/core/src/index/VectorDiskIndex.cpp 0.00% <0.00%> (ø)
internal/core/src/storage/LocalChunkManager.cpp 72.17% <100.00%> (+7.88%) ⬆️
.../core/src/query/visitors/VerifyPlanNodeVisitor.cpp 16.66% <0.00%> (-50.00%) ⬇️
internal/core/src/segcore/pkVisitor.h 25.00% <0.00%> (-25.00%) ⬇️
internal/querycoordv2/dist/dist_handler.go 68.63% <0.00%> (-10.06%) ⬇️
internal/core/src/common/CGoHelper.h 40.00% <0.00%> (-10.00%) ⬇️
internal/core/src/common/Utils.h 46.98% <0.00%> (-9.62%) ⬇️
...al/core/src/query/visitors/ShowPlanNodeVisitor.cpp 79.41% <0.00%> (-9.05%) ⬇️
internal/config/refresher.go 71.79% <0.00%> (-7.70%) ⬇️
internal/core/src/segcore/SegmentInterface.cpp 81.92% <0.00%> (-7.14%) ⬇️
... and 152 more

Copy link
Contributor

@jiaoew1991 jiaoew1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 2, 2023
@sre-ci-robot sre-ci-robot merged commit 4d4bf99 into milvus-io:master Mar 2, 2023
yah01 added a commit to yah01/milvus that referenced this pull request Mar 2, 2023
sre-ci-robot pushed a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants