Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to knowhere-1.3.10 #22614

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Mar 7, 2023

Issue: #22403

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
@sre-ci-robot sre-ci-robot added area/compilation size/XS Denotes a PR that changes 0-9 lines. labels Mar 7, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #22614 (5d00bab) into 2.2.0 (6f85aea) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #22614      +/-   ##
==========================================
- Coverage   81.92%   81.91%   -0.02%     
==========================================
  Files         706      706              
  Lines       99505    99505              
==========================================
- Hits        81523    81511      -12     
- Misses      14852    14860       +8     
- Partials     3130     3134       +4     
Impacted Files Coverage Δ
internal/querycoordv2/task/executor.go 69.66% <0.00%> (-3.09%) ⬇️
internal/proxy/segment.go 87.87% <0.00%> (-1.52%) ⬇️
internal/datacoord/server.go 75.90% <0.00%> (-0.63%) ⬇️
internal/querycoordv2/task/scheduler.go 77.64% <0.00%> (-0.59%) ⬇️
internal/indexcoord/meta_table.go 95.98% <0.00%> (-0.37%) ⬇️
internal/indexcoord/index_builder.go 99.74% <0.00%> (-0.26%) ⬇️
internal/querynode/impl.go 65.67% <0.00%> (-0.18%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.49% <0.00%> (+0.42%) ⬆️
internal/datacoord/session_manager.go 83.67% <0.00%> (+0.51%) ⬆️
internal/util/grpcclient/client.go 78.94% <0.00%> (+1.31%) ⬆️
... and 2 more

@mergify mergify bot added the ci-passed label Mar 7, 2023
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bfe6b24 into milvus-io:2.2.0 Mar 10, 2023
@cydrain cydrain deleted the caiyd_220_fix_tanimoto_calc_error branch March 14, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants