Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Has Collection in datacoord #23709

Merged
merged 1 commit into from Apr 26, 2023

Conversation

xiaofan-luan
Copy link
Contributor

@xiaofan-luan xiaofan-luan commented Apr 25, 2023

related to #23707

The Data coord hasCollection is not working as expected because of Unexpected error

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 25, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Apr 25, 2023
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #23709 (be42e94) into 2.2.0 (8b34f67) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23709      +/-   ##
==========================================
- Coverage   80.61%   80.60%   -0.01%     
==========================================
  Files         713      713              
  Lines      101367   101351      -16     
==========================================
- Hits        81716    81699      -17     
+ Misses      16457    16452       -5     
- Partials     3194     3200       +6     
Impacted Files Coverage Δ
internal/datacoord/handler.go 83.70% <0.00%> (ø)
internal/datacoord/server.go 76.80% <66.66%> (+2.66%) ⬆️
internal/common/error.go 97.53% <100.00%> (+0.06%) ⬆️

... and 18 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Apr 26, 2023

/lgtm

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 26, 2023
@sre-ci-robot sre-ci-robot merged commit 8745ee2 into milvus-io:2.2.0 Apr 26, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants