Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Minio chunk manager GetObject return null value in macOs #24959

Closed
1 task done
zhagnlu opened this issue Jun 16, 2023 · 2 comments
Closed
1 task done

[Bug]: Minio chunk manager GetObject return null value in macOs #24959

zhagnlu opened this issue Jun 16, 2023 · 2 comments
Assignees
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@zhagnlu
Copy link
Contributor

zhagnlu commented Jun 16, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

When use c++ minio chunk manager, GetObject interface return null.

Expected Behavior

GetObject return real value

Steps To Reproduce

1. use disk-ann index when use macOs
2. GetObject return null values.

Milvus Log

No response

Anything else?

the reason:
for reduce memory copy, use ourself buffer to get body from server like:
image

however, stringstream->pubsetbuf has different implement for different system base library.
for linux:
image
actually use new buffer to replace origin.

but for mac:
image
not implement stringstream setbuf interface, and using basic_streambuf which just return, so it can not use our buffer.

@zhagnlu zhagnlu added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 16, 2023
@yanliang567
Copy link
Contributor

/assign @zhagnlu
/unassign

@sre-ci-robot sre-ci-robot assigned zhagnlu and unassigned yanliang567 Jun 16, 2023
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 16, 2023
zhagnlu pushed a commit to zhagnlu/milvus that referenced this issue Jun 20, 2023
Signed-off-by: luzhang <luzhang@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 21, 2023
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
zhagnlu added a commit to zhagnlu/milvus that referenced this issue Jun 27, 2023
…s-io#25002)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 29, 2023
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@stale
Copy link

stale bot commented Jul 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jul 16, 2023
@stale stale bot closed this as completed Jul 23, 2023
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this issue Jul 25, 2023
…us-io#25002)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants