Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetObject return null value bug in MacOs(#24959) #25002

Merged
merged 1 commit into from Jun 21, 2023

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jun 19, 2023

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 19, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jun 19, 2023
@xige-16
Copy link
Contributor

xige-16 commented Jun 19, 2023

fix issue #24836

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #25002 (a716408) into master (2176907) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25002      +/-   ##
==========================================
- Coverage   82.30%   81.93%   -0.38%     
==========================================
  Files         780      791      +11     
  Lines      102682   105026    +2344     
==========================================
+ Hits        84517    86049    +1532     
- Misses      15112    15936     +824     
+ Partials     3053     3041      -12     
Impacted Files Coverage Δ
internal/core/src/storage/MinioChunkManager.cpp 0.00% <ø> (ø)

... and 184 files with indirect coverage changes

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 20, 2023

rerun ut

Signed-off-by: luzhang <luzhang@zilliz.com>
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jun 21, 2023
@sre-ci-robot sre-ci-robot merged commit a79fd1c into milvus-io:master Jun 21, 2023
14 of 15 checks passed
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request Jun 27, 2023
…s-io#25002)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jun 29, 2023
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this pull request Jul 25, 2023
…us-io#25002)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants