New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the kafka panic when sending the message to a closed channel #25116
Conversation
@SimFG E2e jenkins job failed, comment |
@SimFG ut workflow job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
@SimFG E2e jenkins job failed, comment |
…vus-io#25116) Signed-off-by: SimFG <bang.fu@zilliz.com>
/lgtm |
) (#25117) Signed-off-by: SimFG <bang.fu@zilliz.com>
rerun ut |
@SimFG ut workflow job failed, comment |
@SimFG ut workflow job failed, comment |
@SimFG E2e jenkins job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
rerun ut |
@SimFG ut workflow job failed, comment |
Signed-off-by: SimFG <bang.fu@zilliz.com>
Codecov Report
@@ Coverage Diff @@
## 2.2.0 #25116 +/- ##
==========================================
- Coverage 80.66% 80.62% -0.04%
==========================================
Files 761 761
Lines 107554 107554
==========================================
- Hits 86757 86716 -41
- Misses 17478 17509 +31
- Partials 3319 3329 +10 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SimFG, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…vus-io#25116) (milvus-io#25117) Signed-off-by: SimFG <bang.fu@zilliz.com>
issue: #24767
Here the isClosed variable is used instead of select deliveryChan. Because:
If there is a lot of unprocessed information in the kafka producer, it will lead to a longer flush time, and the deliveryChan will be closed and delayed, so there is still a risk of panic, so here when the producer close method is called, first set the isClosed variable. And before send, firstly judge the value of isClosed