Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the kafka panic when sending the message to a closed channel #25116

Merged
merged 1 commit into from Jun 28, 2023

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jun 25, 2023

issue: #24767

Here the isClosed variable is used instead of select deliveryChan. Because:

If there is a lot of unprocessed information in the kafka producer, it will lead to a longer flush time, and the deliveryChan will be closed and delayed, so there is still a risk of panic, so here when the producer close method is called, first set the isClosed variable. And before send, firstly judge the value of isClosed

@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo June 25, 2023 08:57
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 25, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jun 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 25, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 26, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG added a commit to SimFG/milvus that referenced this pull request Jun 26, 2023
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

sre-ci-robot pushed a commit that referenced this pull request Jun 27, 2023
@SimFG
Copy link
Contributor Author

SimFG commented Jun 27, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 27, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 27, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 27, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 27, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 28, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jun 28, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: SimFG <bang.fu@zilliz.com>
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #25116 (e23dfbd) into 2.2.0 (e09da3b) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25116      +/-   ##
==========================================
- Coverage   80.66%   80.62%   -0.04%     
==========================================
  Files         761      761              
  Lines      107554   107554              
==========================================
- Hits        86757    86716      -41     
- Misses      17478    17509      +31     
- Partials     3319     3329      +10     

see 17 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 28, 2023
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bd17544 into milvus-io:2.2.0 Jun 28, 2023
11 checks passed
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants