Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default nb to 2000 #25169

Merged
merged 1 commit into from Jun 28, 2023
Merged

Update default nb to 2000 #25169

merged 1 commit into from Jun 28, 2023

Conversation

NicoYuan1986
Copy link
Contributor

from #24925

@sre-ci-robot sre-ci-robot added area/test size/L Denotes a PR that changes 100-499 lines. sig/testing labels Jun 27, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jun 27, 2023
binbinlv
binbinlv reviewed Jun 27, 2023
View reviewed changes
tests/python_client/common/common_func.py Outdated
distance_i = l2(x, y[i])
elif metric == "IP":
distance_i = ip(x, y[i])
elif metric == "COSINE":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here needs to be removed.

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@NicoYuan1986
Update default nb to 2000
2fd0746 
Signed-off-by: nico <cheng.yuan@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

3 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 27, 2023
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NicoYuan1986, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f80afb1 into milvus-io:2.2.0 Jun 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbinlv binbinlv binbinlv left review comments

@ThreadDao ThreadDao Awaiting requested review from ThreadDao

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@yanliang567 yanliang567

Labels
approved area/test ci-passed dco-passed DCO check passed. lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NicoYuan1986 @yanliang567 @sre-ci-robot @binbinlv