Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errcode to minio chunkmanager exception(#25153) #25181

Merged
merged 1 commit into from Jun 28, 2023

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jun 27, 2023

Signed-off-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 27, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #25181 (88f6c42) into 2.2.0 (936ebf3) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25181      +/-   ##
==========================================
+ Coverage   80.63%   80.65%   +0.02%     
==========================================
  Files         761      761              
  Lines      107527   107527              
==========================================
+ Hits        86704    86730      +26     
+ Misses      17499    17477      -22     
+ Partials     3324     3320       -4     
Impacted Files Coverage Δ
internal/core/src/storage/MinioChunkManager.cpp 0.00% <ø> (ø)

... and 14 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 27, 2023
@czs007
Copy link
Contributor

czs007 commented Jun 28, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2c722a9 into milvus-io:2.2.0 Jun 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants