Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rootcoord restoration misses gcConfirmStep #25280

Merged
merged 1 commit into from Jul 4, 2023

Conversation

congqixia
Copy link
Contributor

See also #25279
/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jul 3, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 3, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Jul 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jul 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor

/lgtm

@longjiquan
Copy link
Contributor

Thx for the great fix.

@czs007
Copy link
Contributor

czs007 commented Jul 3, 2023

@congqixia need to pick to master

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

@congqixia need to pick to master

@czs007 done: #25293

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #25280 (3201f76) into 2.2.0 (4b916f2) will decrease coverage by 0.03%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25280      +/-   ##
==========================================
- Coverage   80.63%   80.60%   -0.03%     
==========================================
  Files         761      761              
  Lines      107547   107583      +36     
==========================================
- Hits        86725    86722       -3     
- Misses      17496    17527      +31     
- Partials     3326     3334       +8     
Impacted Files Coverage Δ
internal/querynode/plan.go 68.61% <40.00%> (-3.27%) ⬇️
internal/rootcoord/garbage_collector.go 98.36% <100.00%> (+0.06%) ⬆️

... and 25 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jul 4, 2023
@sre-ci-robot sre-ci-robot merged commit 2129166 into milvus-io:2.2.0 Jul 4, 2023
10 of 11 checks passed
czs007 pushed a commit that referenced this pull request Jul 4, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants