Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression on integer overflow case #25320

Merged
merged 1 commit into from Jul 5, 2023

Conversation

longjiquan
Copy link
Contributor

/kind improvement

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 4, 2023
@sre-ci-robot sre-ci-robot added area/compilation size/XL Denotes a PR that changes 500-999 lines. labels Jul 4, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #25320 (3353a39) into master (595d04e) will decrease coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25320      +/-   ##
==========================================
- Coverage   81.99%   81.36%   -0.64%     
==========================================
  Files         798      812      +14     
  Lines      105592   108216    +2624     
==========================================
+ Hits        86582    88047    +1465     
- Misses      15941    17088    +1147     
- Partials     3069     3081      +12     
Impacted Files Coverage Δ
...ternal/core/src/query/visitors/ExecExprVisitor.cpp 73.18% <100.00%> (-1.90%) ⬇️

... and 209 files with indirect coverage changes

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 4, 2023
@czs007
Copy link
Contributor

czs007 commented Jul 5, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c2a2ece into milvus-io:master Jul 5, 2023
14 of 15 checks passed
@longjiquan longjiquan deleted the interger-overflow-ut branch July 5, 2023 02:43
longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 6, 2023
…5372)

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jul 7, 2023
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this pull request Jul 25, 2023
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants