Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-Pick]: Prevent exclusive consumer exception in pulsar (#25376) #25378

Merged
merged 1 commit into from Jul 13, 2023
Merged

[Cherry-Pick]: Prevent exclusive consumer exception in pulsar (#25376) #25378

merged 1 commit into from Jul 13, 2023

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jul 6, 2023 •
edited

issue: #25267 #25334
origin pr: #25376

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 6, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jul 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 7, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 7, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 7, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 11, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Jul 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot removed the needs-rebase label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited

Codecov Report

Merging #25378 (9499fb7) into 2.2.0 (96ba92d) will increase coverage by 0.04%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25378      +/-   ##
==========================================
+ Coverage   80.67%   80.71%   +0.04%     
==========================================
  Files         765      765              
  Lines      109312   109321       +9     
==========================================
+ Hits        88182    88236      +54     
+ Misses      17731    17688      -43     
+ Partials     3399     3397       -2
Impacted Files Coverage Δ
...nternal/datanode/flow_graph_dmstream_input_node.go 88.88% <0.00%> (-4.14%) ⬇️
internal/datanode/data_node.go 79.20% <100.00%> (+0.03%) ⬆️
internal/datanode/event_manager.go 82.22% <100.00%> (+0.82%) ⬆️
internal/querynode/flow_graph_query_node.go 75.58% <100.00%> (+0.14%) ⬆️

... and 21 files with indirect coverage changes

@SimFG
Prevent exclusive consumer exception in pulsar (milvus-io#25376)
9499fb7 
Signed-off-by: SimFG <bang.fu@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 12, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 13, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 13, 2023

rerun ut

@mergify mergify bot added the ci-passed label Jul 13, 2023
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c14a251 into milvus-io:2.2.0 Jul 13, 2023
11 checks passed
@PowderLi PowderLi mentioned this pull request Aug 28, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@sunby sunby Awaiting requested review from sunby

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimFG @xiaofan-luan @sre-ci-robot