Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleted data may be returned by search/query #25513

Merged
merged 1 commit into from Jul 13, 2023

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jul 12, 2023

issue: #25512

@sunby sunby requested review from congqixia and yah01 July 12, 2023 03:08
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 12, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

internal/querynode/segment_loader.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: sunby <bingyi.sun@zilliz.com>
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #25513 (65eef4b) into 2.2.0 (96ba92d) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25513      +/-   ##
==========================================
- Coverage   80.67%   80.63%   -0.04%     
==========================================
  Files         765      765              
  Lines      109312   109342      +30     
==========================================
- Hits        88182    88169      -13     
- Misses      17731    17766      +35     
- Partials     3399     3407       +8     
Impacted Files Coverage Δ
internal/querynode/watch_dm_channels_task.go 78.00% <33.33%> (-1.46%) ⬇️

... and 19 files with indirect coverage changes

@yah01
Copy link
Member

yah01 commented Jul 13, 2023

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jul 13, 2023
@czs007 czs007 added this to the 2.2.12 milestone Jul 13, 2023
@sre-ci-robot sre-ci-robot merged commit 605d1aa into milvus-io:2.2.0 Jul 13, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants