Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sync segmentLastExpire every time when assigning(#25271) (#25316) #25557

Merged
merged 1 commit into from Jul 24, 2023

Conversation

MrPresent-Han
Copy link
Contributor

related: #25271

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 13, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

…) (milvus-io#25316)

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #25557 (f66aac5) into master (32827f5) will increase coverage by 0.01%.
The diff coverage is 87.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25557      +/-   ##
==========================================
+ Coverage   82.17%   82.19%   +0.01%     
==========================================
  Files         801      801              
  Lines      106523   106579      +56     
==========================================
+ Hits        87537    87602      +65     
+ Misses      15906    15897       -9     
  Partials     3080     3080              
Impacted Files Coverage Δ
internal/datacoord/server.go 61.06% <40.00%> (-0.61%) ⬇️
internal/datacoord/meta.go 87.93% <87.50%> (+0.65%) ⬆️
internal/datacoord/segment_manager.go 89.06% <100.00%> (-0.26%) ⬇️
pkg/util/paramtable/component_param.go 97.98% <100.00%> (+<0.01%) ⬆️
pkg/util/paramtable/param_item.go 90.09% <100.00%> (+0.20%) ⬆️

... and 18 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 23, 2023
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f4e72cb into milvus-io:master Jul 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants