Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk metric info #25678

Merged
merged 1 commit into from Aug 22, 2023
Merged

Add disk metric info #25678

merged 1 commit into from Aug 22, 2023

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jul 17, 2023

/kind improvement

pr: #25675
Signed-off-by: xige-16 xi.ge@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 17, 2023
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 17, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #25678 (e51bf34) into 2.2.0 (27fe2a4) will decrease coverage by 0.01%.
The diff coverage is 51.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25678      +/-   ##
==========================================
- Coverage   81.00%   81.00%   -0.01%     
==========================================
  Files         770      770              
  Lines      110578   110598      +20     
==========================================
+ Hits        89578    89589      +11     
- Misses      17630    17637       +7     
- Partials     3370     3372       +2     
Files Changed Coverage Δ
internal/core/src/storage/storage_c.cpp 0.00% <0.00%> (ø)
internal/indexnode/task.go 41.05% <0.00%> (-1.33%) ⬇️
internal/util/indexcgowrapper/helper.go 60.65% <0.00%> (-2.06%) ⬇️
internal/querynode/query_node.go 68.55% <42.85%> (-1.34%) ⬇️
internal/metrics/querynode_metrics.go 100.00% <100.00%> (ø)
internal/querynode/cgo_helper.go 77.27% <100.00%> (+1.08%) ⬆️
internal/querynode/segment_loader.go 80.97% <100.00%> (+0.02%) ⬆️

... and 21 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Jul 28, 2023

/approve
/lgtm

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Aug 8, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@xige-16 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Aug 9, 2023

#25675

@xige-16
Copy link
Contributor Author

xige-16 commented Aug 9, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Aug 9, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Aug 16, 2023

rerun ut

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Aug 22, 2023
@czs007
Copy link
Contributor

czs007 commented Aug 22, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1ea4771 into milvus-io:2.2.0 Aug 22, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants