Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support json_contains #25724

Merged
merged 1 commit into from Jul 19, 2023
Merged

Conversation

czs007
Copy link
Contributor

@czs007 czs007 commented Jul 18, 2023

issue #24677

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

Co-authored-by: cai.zhang <cai.zhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Contributor Author

czs007 commented Jul 18, 2023

/hold

@sre-ci-robot sre-ci-robot added do-not-merge/hold size/XXL Denotes a PR that changes 1000+ lines. labels Jul 18, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

@czs007 ut workflow job failed, comment rerun ut can trigger the job again.

@czs007 czs007 added this to the 2.2.12 milestone Jul 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

@czs007 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #25724 (a6c94a4) into 2.2.0 (0567128) will increase coverage by 0.05%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25724      +/-   ##
==========================================
+ Coverage   80.83%   80.88%   +0.05%     
==========================================
  Files         766      766              
  Lines      109725   109813      +88     
==========================================
+ Hits        88693    88820     +127     
+ Misses      17641    17608      -33     
+ Partials     3391     3385       -6     
Impacted Files Coverage Δ
...nternal/core/src/query/generated/ExecExprVisitor.h 100.00% <ø> (ø)
internal/metastore/kv/indexcoord/kv_catalog.go 83.47% <63.63%> (-2.24%) ⬇️
internal/proxy/multi_rate_limiter.go 87.79% <66.66%> (-0.99%) ⬇️
...ternal/core/src/query/visitors/ExecExprVisitor.cpp 77.02% <91.30%> (+0.33%) ⬆️
internal/core/src/query/Expr.h 86.20% <100.00%> (ø)
internal/core/src/query/ExprImpl.h 100.00% <100.00%> (ø)
internal/core/src/query/Parser.cpp 93.67% <100.00%> (+0.02%) ⬆️
internal/core/src/query/PlanProto.cpp 83.91% <100.00%> (ø)
internal/parser/planparserv2/parser_visitor.go 86.66% <100.00%> (+0.91%) ⬆️
internal/parser/planparserv2/plan_parser_v2.go 90.32% <100.00%> (+0.21%) ⬆️
... and 1 more

... and 18 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 19, 2023
@czs007
Copy link
Contributor Author

czs007 commented Jul 19, 2023

/unhold

@xiaocai2333
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 9504a37 into milvus-io:2.2.0 Jul 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants