Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datacoord consume datanode tt metrics #25761

Merged

Conversation

weiliu1031
Copy link
Contributor

Signed-off-by: Wei Liu wei.liu@zilliz.com

/kind improvement

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Jul 19, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #25761 (110625e) into 2.2.0 (0dac3fc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25761      +/-   ##
==========================================
+ Coverage   80.82%   80.85%   +0.03%     
==========================================
  Files         766      766              
  Lines      109734   109874     +140     
==========================================
+ Hits        88688    88840     +152     
+ Misses      17656    17652       -4     
+ Partials     3390     3382       -8     
Impacted Files Coverage Δ
internal/datacoord/services.go 83.14% <100.00%> (ø)
internal/datanode/timetick_sender.go 100.00% <100.00%> (ø)

... and 42 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 19, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added ci-passed and removed ci-passed labels Jul 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 20, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1863056 into milvus-io:2.2.0 Jul 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants