Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datanode/datacoord continuous restart #26470

Merged
merged 1 commit into from Aug 20, 2023
Merged

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Aug 18, 2023

issue: #25905

Signed-off-by: SimFG <bang.fu@zilliz.com>
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #26470 (26aeeb3) into master (3b11ad2) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26470      +/-   ##
==========================================
- Coverage   79.87%   79.86%   -0.01%     
==========================================
  Files         821      821              
  Lines      112322   112328       +6     
==========================================
- Hits        89712    89707       -5     
- Misses      19408    19414       +6     
- Partials     3202     3207       +5     
Files Changed Coverage Δ
internal/datacoord/handler.go 83.50% <0.00%> (-0.30%) ⬇️
internal/datanode/data_sync_service.go 78.50% <0.00%> (-0.78%) ⬇️
internal/datanode/event_manager.go 81.25% <33.33%> (-1.73%) ⬇️

... and 16 files with indirect coverage changes

@xiaofan-luan xiaofan-luan added this to the 2.3 milestone Aug 20, 2023
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3be4ac4 into milvus-io:master Aug 20, 2023
13 of 14 checks passed
SimFG added a commit to SimFG/milvus that referenced this pull request Aug 21, 2023
Signed-off-by: SimFG <bang.fu@zilliz.com>
SimFG added a commit to SimFG/milvus that referenced this pull request Aug 22, 2023
Signed-off-by: SimFG <bang.fu@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Aug 23, 2023
Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants