Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression incompatible between parser and executor #26493

Merged
merged 1 commit into from Aug 21, 2023

Conversation

longjiquan
Copy link
Contributor

@longjiquan longjiquan commented Aug 21, 2023

issue: #26275
/kind bug

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 21, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

longjiquan added a commit to longjiquan/milvus that referenced this pull request Aug 21, 2023
)

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@longjiquan
Copy link
Contributor Author

rerun ut

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Aug 21, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Aug 21, 2023
)

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #26493 (f593df0) into master (1e28c6e) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26493   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files         821      821           
  Lines      112433   112444   +11     
=======================================
+ Hits        89769    89781   +12     
  Misses      19457    19457           
+ Partials     3207     3206    -1     
Files Changed Coverage Δ
internal/parser/planparserv2/node_ret.go 80.00% <ø> (ø)
internal/parser/planparserv2/parser_visitor.go 88.92% <100.00%> (+0.10%) ⬆️
internal/parser/planparserv2/plan_parser_v2.go 92.10% <100.00%> (ø)
internal/parser/planparserv2/utils.go 87.62% <100.00%> (+0.08%) ⬆️

... and 19 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Aug 21, 2023
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants