Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat balance task with released source segment as stale (#26453) #26498

Merged
merged 1 commit into from Aug 23, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Aug 21, 2023

/kind improvement
pr: #26453

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/L Denotes a PR that changes 100-499 lines. labels Aug 21, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@yah01 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@yah01
Copy link
Member Author

yah01 commented Aug 21, 2023

pr: #26453

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Aug 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #26498 (ca1b7f5) into 2.2.0 (4110e39) will decrease coverage by 0.01%.
Report is 9 commits behind head on 2.2.0.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #26498      +/-   ##
==========================================
- Coverage   80.97%   80.97%   -0.01%     
==========================================
  Files         773      773              
  Lines      110683   110769      +86     
==========================================
+ Hits        89629    89690      +61     
- Misses      17674    17699      +25     
  Partials     3380     3380              
Files Changed Coverage Δ
internal/querycoordv2/task/scheduler.go 78.50% <64.28%> (-0.08%) ⬇️

... and 35 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 20e3011 into milvus-io:2.2.0 Aug 23, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants