(db/snapshots): Integration and Enhancement #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuPeng-SH
added
kind/feature
Codecov Report
@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
- Coverage 78.92% 78.32% -0.61%
==========================================
Files 428 432 +4
Lines 27510 27762 +252
==========================================
+ Hits 21713 21744 +31
- Misses 5797 6018 +221
|
cydrain
reviewed
Jun 26, 2020
cydrain
reviewed
Jun 26, 2020
cydrain
reviewed
Jun 28, 2020
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
Signed-off-by: peng.xu <peng.xu@zilliz.com>
cydrain
reviewed
Jul 1, 2020
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <map> | |||
cydrain
reviewed
Jul 1, 2020
| SSDBImpl::DropCollection(const std::string& name) { | ||
| CHECK_INITIALIZED; | ||
|
|
||
| // dates partly delete files of the collection but currently we don't support |
There was a problem hiding this comment.
this comment seems not readable
cydrain
reviewed
Jul 1, 2020
| return Status::OK(); | ||
| } | ||
| if (context_ && context_->IsConnectionBroken()) { | ||
| LOG_ENGINE_DEBUG_ << "Client connection broken, stop load collection"; |
cydrain
reviewed
Jul 1, 2020
|
|
||
| // SS TODO | ||
| auto element_handler = std::make_shared<LoadVectorFieldElementHandler>(context_, ss_, field); | ||
| element_handler->Iterate(); |
There was a problem hiding this comment.
it's not clear what "Iterate()" does internally.
Is it possible write the code in this way:
for (auto elem_iter = element_handler->begin(); elem_iter != element_handler->end(); elem_iter = element_handler->next()) {
/* do something */
}
cydrain
reviewed
Jul 1, 2020
| @@ -24,8 +24,10 @@ using NUM_TYPE = int64_t; | |||
| using FTYPE_TYPE = int64_t; | |||
| using TS_TYPE = int64_t; | |||
| using LSN_TYPE = uint64_t; | |||
There was a problem hiding this comment.
suggest to use int64_t everywhere for ease of debug
cydrain
approved these changes
Jul 1, 2020
wxyucs
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
api-change / bug / improvement / documentation / feature
Need this PR be picked to master branch?
Yes / No
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation (e.g. design docs, usage docs, etc.):