#2642 Create index failed caused by server crashed. #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yhmo <yihua.mo@zilliz.com>
cydrain
reviewed
Jul 1, 2020
| @@ -112,6 +112,22 @@ BinaryIDMAP::QueryById(const DatasetPtr& dataset_ptr, const Config& config) { | |||
| } | |||
| #endif | |||
|
|
|||
| int64_t | |||
| BinaryIDMAP::Count() { | |||
| if (!index_) { | |||
There was a problem hiding this comment.
server crash is caused by "index_" not initialized ?
why ?
There was a problem hiding this comment.
No reason for the problem was found, but it would have prevented the server from crashing. @cydrain
shengjun1985
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yhmo yihua.mo@zilliz.com
What type of PR is this?
api-change / bug / improvement / documentation / feature
Need this PR be picked to master branch?
Yes
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation (e.g. design docs, usage docs, etc.):