Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the mock factory of msg stream #27834

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Oct 20, 2023

/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 20, 2023
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Oct 20, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 20, 2023
@czs007
Copy link
Contributor

czs007 commented Oct 20, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #27834 (04a6efa) into master (babf4e3) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27834      +/-   ##
==========================================
+ Coverage   81.71%   81.73%   +0.01%     
==========================================
  Files         819      819              
  Lines      116062   116062              
==========================================
+ Hits        94845    94867      +22     
+ Misses      18048    18027      -21     
+ Partials     3169     3168       -1     

see 12 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 20, 2023
@sre-ci-robot sre-ci-robot merged commit 086220d into milvus-io:master Oct 20, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants